-1 (binding) There are a few issues with license/notice documentation:
cpplint.py has a copyright notice, “Copyright (c) 2009 Google Inc.” and a 3-clause BSD license that is missing for LICENSE.txt NOTICE.txt contains license information that should only be in LICENSE.txt (the inclusion of PFOR code). ASF guidance states: “Do not add anything to NOTICE which is not legally required” so this should be removed from the candidate. .travis.yml has no header Also, the tag points to commit 431bcce4, which isn’t the commit id in this vote. The signature and build look fine to me, but I didn’t run tests. rb On Sun, Feb 26, 2017 at 11:10 AM, Wes McKinney [email protected] wrote: hi Deepak, Thank you very much for catching this. It appears that Travis CI silently upgraded our build image to Xcode 7.3 last fall — we should have pegged our builds on Xcode 6.4 which is currently the recommended image for supporting Mac users back to OS 10 .9. I confirm that I also cannot build the project out of the box on Xcode 6.4. I had two issues, one caused by an old OpenSSL on my machine (OS 10.11) and the second caused by Googletest. It appears to be a problem with our Googletest Thirdparty setup — if I use the libgtest.a artifact produced by conda-forge with Xcode 6.4, then I do not have any test linking problems: https://github.com/conda-forge/gtest-feedstock. I ran the unit tests this way and they all pass While this is disappointing, I don’t believe it should block the release. I’m opening a JIRA for fixing our thirdparty build on Xcode 6.4 and changing out Travis CI build to use 6.4 also. Thanks, Wes On Sun, Feb 26, 2017 at 11:02 AM, Deepak Majeti [email protected] wrote: Wes, I tested with Xcode 6.4, Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn). I also noticed that the build fails using GCC 4.9.4 and 5.4.0 on OSX. Looks like the option ‘-stdlib=libc++’ works only with Clang. On Sun, Feb 26, 2017 at 9:34 AM, Wes McKinney [email protected] wrote: @Deepak: which version of XCode is the clang 3.6.0 from? I’d like to look into it On Sun, Feb 26, 2017 at 8:30 AM Deepak Majeti [email protected] wrote: Debug build failed on OSX with Clang 3.6.0 Debug build passed on OSX with Clang 3.8.1 Debug build passed on Ubuntu 16.04 with GCC 4.9.4 +1 (non-binding) Thanks, Uwe. On Fri, Feb 24, 2017 at 5:21 PM, Wes McKinney [email protected] wrote: @Uwe, I suggest we prefix the RC directory names with apache-parquet-cpp- in https://dist.apache.org/repos/dist/dev/parquet/ to help disambiguate the RCs of the different subcomponents. On Ubuntu 14.04: Debug build and ran tests with valgrind —tool=memcheck with gcc 4.8.5 Release build with gcc 4.9.2, ran unit tests, tested Python Arrow integration Debug build with Clang 3.8.0 and ran unit tests Verified tarball signature +1 (binding) Thank you, Uwe! On Fri, Feb 24, 2017 at 4:49 PM, Julien Le Dem [email protected] wrote: Verified the release on OSX: dev/release/verify-release-candidate 1.0.0 3 Checked the content and output of the verification script. The verification script is awesome. Thanks Uwe! Side question: would it actually stop and fail if - let’s say - the signature verification failed? +1 (binding) On Fri, Feb 24, 2017 at 1:39 AM, Uwe L. Korn [email protected] wrote: Verified release on OSX and Linux with “./dev/release/verify-release-candidate 1.0.0 3” Also build and tested pyarrow parquet integration. Therefore +1 (non-binding) — Uwe L. Korn [email protected] On Thu, Feb 23, 2017, at 08:28 PM, Uwe L. Korn wrote: All, I propose that we accept the following release candidate as the official Apache Parquet C++ 1.0.0 release. Parquet C++ 1.0.0-rc3 includes the following: The CHANGELOG for the release is available at: https://git-wip-us.apache.org/repos/asf?p=parquet-cpp.git&f= CHANGELOG&hb=apache-parquet-cpp-1.0.0-rc3 The tag used to create the release candidate is: https://git-wip-us.apache.org/repos/asf?p=parquet-cpp.git;a= shortlog;h=refs/tags/apache-parquet-cpp-1.0.0-rc3 The release candidate is available at: https://dist.apache.org/repos/dist/dev/parquet/1.0.0-rc3/ apache-parquet-cpp-1.0.0.tar.gz The MD5 checksum of the release candidate can be found at: https://dist.apache.org/repos/dist/dev/parquet/1.0.0-rc3/ apache-parquet-cpp-1.0.0.tar.gz.md5 The signature of the release candidate can be found at: https://dist.apache.org/repos/dist/dev/parquet/1.0.0-rc3/ apache-parquet-cpp-1.0.0.tar.gz.asc The GPG key used to sign the release are available at: https://dist.apache.org/repos/dist/dev/parquet/KEYS The release is based on the commit hash d56f4bdeb968255bff160eafd625734386b1ea6b. Please download, verify, and test. The vote will close on So 26 Feb 2017 20:27:20 CET [ ] +1 Release this as Apache Parquet C++ 1.0.0 [ ] +0 [ ] -1 Do not release this as Apache Parquet C++ 1.0.0 because… —————————————————————————————— Also note that I skipped RC2 because there were issues in the signing process. — Uwe L. Korn [email protected] — Julien — regards, Deepak Majeti — regards, Deepak Majeti -- Ryan Blue Software Engineer Netflix
