Thanks, Wes! I should read more carefully next time. I'm changing my vote to +1. I also ran the release audit and everything looks good.
On Mon, Mar 13, 2017 at 3:10 PM, Wes McKinney <[email protected]> wrote: > This is in the README > > "The test suite relies on an environment variable PARQUET_TEST_DATA > pointing to the data directory in the source checkout, for example: > > export PARQUET_TEST_DATA=`pwd`/data" > > so if you set the env variable according to the `pwd` of the untarred > source tree then reader-test should pass > > On Mon, Mar 13, 2017 at 6:00 PM, Ryan Blue <[email protected]> > wrote: > > Uwe, thanks for make the RCs. It’s great to have someone to push this > > through. > > > > Why does the release tarball have different hash? Shouldn’t the release > > tarball use the release hash? In git, the rc5 tag points to the tarball > > commit, so I think everything is fine and the commit covered by this vote > > is 221d4b78d957000e3a6afe29cc385a295b938329. In the future, I’d like to > see > > just one commit so it is clear what is being voted on. > > > > The signatures and checksums look good. The build succeeds, but one test > > fails: > > > >> make unittest > > ... > > Start 5: reader-test > > 5/19 Test #5: reader-test ......................***Failed 0.03 sec > > > > I don’t know if that’s a problem or not. Unless someone can tell me what > > I’m doing wrong, my vote is +0. > > > > rb > > > > > > On Mon, Mar 13, 2017 at 2:32 PM, Ryan Blue <[email protected]> wrote: > > > >> Will do, sorry for the delay. > >> > >> On Mon, Mar 13, 2017 at 2:31 PM, Wes McKinney <[email protected]> > wrote: > >> > >>> hi Uwe, > >>> > >>> Thank you for making the release candidate. > >>> > >>> I have > >>> > >>> * Built and run the unit tests (Ubuntu 14.04, gcc 4.8.5) > >>> * Verified the MD5 signature > >>> * Verified the GPG signature > >>> > >>> My vote: +1 (binding) > >>> > >>> @Ryan or @Julien, since we're running a bit short on the voting window > >>> would you mind taking a look at the RC today? If any other PMCs can > >>> take a look today to help verify the release that would be very > >>> helpful. > >>> > >>> Thanks, > >>> Wes > >>> > >>> On Sat, Mar 11, 2017 at 12:18 PM, Uwe L. Korn <[email protected]> > wrote: > >>> > All, > >>> > > >>> > I propose that we accept the following release candidate as the > official > >>> > Apache Parquet C++ 1.0.0 release. > >>> > > >>> > Parquet C++ 1.0.0-rc5 includes the following: > >>> > --- > >>> > The CHANGELOG for the release is available at: > >>> > https://git-wip-us.apache.org/repos/asf?p=parquet-cpp.git&f= > >>> CHANGELOG&hb=apache-parquet-cpp-1.0.0-rc5 > >>> > > >>> > The tag used to create the release candidate is: > >>> > https://git-wip-us.apache.org/repos/asf?p=parquet-cpp.git;a= > >>> shortlog;h=refs/tags/apache-parquet-cpp-1.0.0-rc5 > >>> > > >>> > The release candidate is available at: > >>> > https://dist.apache.org/repos/dist/dev/parquet/apache-parque > >>> t-cpp-1.0.0-rc5/apache-parquet-cpp-1.0.0.tar.gz > >>> > > >>> > The MD5 checksum of the release candidate can be found at: > >>> > https://dist.apache.org/repos/dist/dev/parquet/apache-parque > >>> t-cpp-1.0.0-rc5/apache-parquet-cpp-1.0.0.tar.gz.md5 > >>> > > >>> > The signature of the release candidate can be found at: > >>> > https://dist.apache.org/repos/dist/dev/parquet/apache-parque > >>> t-cpp-1.0.0-rc5/apache-parquet-cpp-1.0.0.tar.gz.asc > >>> > > >>> > The GPG key used to sign the release are available at: > >>> > https://dist.apache.org/repos/dist/dev/parquet/KEYS > >>> > > >>> > The release is based on the commit hash > >>> > 7148cf033fb06c33d40ee57fc76577cdea6cd89a, the commit hash for the > >>> > tarball (that includes the commit setting the correct version > number) is > >>> > 221d4b78d957000e3a6afe29cc385a295b938329. > >>> > > >>> > Please download, verify, and test. > >>> > > >>> > The vote will close on Tue 14. Mär 18:04:03 CET 2017 > >>> > > >>> > [ ] +1 Release this as Apache Parquet C++ 1.0.0 > >>> > [ ] +0 > >>> > [ ] -1 Do not release this as Apache Parquet C++ 1.0.0 because... > >>> > > >>> > ------------------------------------------------------------ > >>> -------------------- > >>> > > >>> > +1 (non-binding), I have run the build & tests successfully on OSX > and > >>> > Linux with "bash ./dev/release/verify-release-candidate 1.0.0 5" > (note > >>> > that you need to use the fixed version from > >>> > https://github.com/apache/parquet-cpp/pull/269 as we have changed > the > >>> > name of the tarball since the last RC). > >>> > > >>> > Uwe > >>> > >> > >> > >> > >> -- > >> Ryan Blue > >> Software Engineer > >> Netflix > >> > > > > > > > > -- > > Ryan Blue > > Software Engineer > > Netflix > -- Ryan Blue Software Engineer Netflix
