After some more testing, I must revise my vote to -1. Encountered a core dump on a test file. Patch here:
https://github.com/apache/parquet-cpp/pull/337 On Thu, May 18, 2017 at 2:06 AM, Julien Le Dem <[email protected]> wrote: > +1 (binding) > > Verified signature, build & tested using > `./dev/release/verify-release-candidate 1.1.0 0` on macOS > > I had to clean up an old version of arrow in /usr/local : > > /usr/local//lib/pkgconfig/arrow.pc > > /usr/local/include/arrow > > > > On Wed, May 17, 2017 at 10:03 PM, Wes McKinney <[email protected]> wrote: > >> +1 (binding) >> >> * Verified signature >> * Build from minimal env and run unit tests on Linux (Ubuntu 14.04), >> built against Arrow 0.4.0 RC0 and ran Python unit tests >> * Built RC with Visual Studio 2015 against Apache Arrow 0.4.0 rc0, >> built Python extension and ran unit tests. The Visual Studio build is >> ugly (lots of compiler warnings), so we should clean this up in the >> next release (PARQUET-991) >> >> As one snafu while I was verifying the MSVC build: the Arrow hash in >> the thirdparty setup is not ABI compatible with Arrow 0.4.0 rc0 >> because of ARROW-182. I had to build Arrow first then set ARROW_HOME. >> This presented initially as the pyarrow.parquet tests simply not >> running; I had to load the DLLs manually to catch the ABI mismatch. >> This is bad because I don't think this will break our Travis CI setup >> in Arrow if there is an ABI conflict. I don't think this is a blocker >> in either Arrow or parquet-cpp but definitely a rough edge we should >> fix >> >> On Wed, May 17, 2017 at 4:34 PM, Uwe L. Korn <[email protected]> wrote: >> > +1 (binding) >> > >> > Verified signature, build & tested using >> > `./dev/release/verify-release-candidate 1.1.0 0` on Linux and macOS >> > >> > >> > >> > On Wed, May 17, 2017, at 09:27 PM, Uwe L. Korn wrote: >> >> All, >> >> >> >> I propose that we accept the following release candidate as the official >> >> Apache Parquet C++ 1.1.0 release. >> >> >> >> Parquet C++ 1.1.0-rc0 includes the following: >> >> --- >> >> The CHANGELOG for the release is available at: >> >> https://git-wip-us.apache.org/repos/asf?p=parquet-cpp.git&f= >> CHANGELOG&hb=apache-parquet-cpp-1.1.0-rc0 >> >> >> >> The tag used to create the release candidate is: >> >> https://git-wip-us.apache.org/repos/asf?p=parquet-cpp.git;a= >> shortlog;h=refs/tags/apache-parquet-cpp-1.1.0-rc0 >> >> >> >> The release candidate is available at: >> >> https://dist.apache.org/repos/dist/dev/parquet/apache- >> parquet-cpp-1.1.0-rc0/apache-parquet-cpp-1.1.0.tar.gz >> >> >> >> The MD5 checksum of the release candidate can be found at: >> >> https://dist.apache.org/repos/dist/dev/parquet/apache- >> parquet-cpp-1.1.0-rc0/apache-parquet-cpp-1.1.0.tar.gz.md5 >> >> >> >> The signature of the release candidate can be found at: >> >> https://dist.apache.org/repos/dist/dev/parquet/apache- >> parquet-cpp-1.1.0-rc0/apache-parquet-cpp-1.1.0.tar.gz.asc >> >> >> >> The GPG key used to sign the release are available at: >> >> https://dist.apache.org/repos/dist/dev/parquet/KEYS >> >> >> >> The release is based on the commit hash >> >> aff9235b239f5bc51a419f473ae8a6a16156e749. >> >> >> >> Please download, verify, and test. >> >> >> >> The vote will close on Sa 20. Mai 21:26:06 CEST 2017 >> >> >> >> [ ] +1 Release this as Apache Parquet C++ 1.1.0 >> >> [ ] +0 >> >> [ ] -1 Do not release this as Apache Parquet C++ 1.1.0 because... >> >> >> >> Uwe >> > > > > -- > Julien
