0 (non-binding) * Verified the sha512 sum * Verified the .asc and that it matches Uwe's key * Built and ran the unittests manually on macOS Sierra * Ran the rat tool over the tarball. All warnings looked expected to me except for apache-parquet-cpp-1.3.1/cmake_modules/parquet-cppConfig.cmake.in, which I think needs a license header.
Would +1 after a license has been added to that file. I created https://github.com/apache/parquet-cpp/pull/411 to fix this. Thank you Uwe for preparing the release! On Mon, Oct 16, 2017 at 12:47 AM, Uwe L. Korn <[email protected]> wrote: > +1 > > * Ran verify-release-candidate on Ubuntu 16.04 > * Ran verify-release-candidate on macOS Sierra > > -- > Uwe L. Korn > [email protected] > > On Mon, Oct 16, 2017, at 02:16 AM, Wes McKinney wrote: > > +1 > > > > * Ran verify-release-candidate on Ubuntu 14.04 > > > > In trying to verify the release candidate on MSVC / Visual Studio > > 2015, I found that arrow-reader-writer-test.cc does not compile > > against Arrow 0.7.1. The version in ThirdpartyToolchain.cmake is > > post-0.7.1 > > > > I posted this fix, which also tests 0.7.1 on all the platforms: > > https://github.com/apache/parquet-cpp/pull/410. So I don't think it's > > necessary to cancel the RC over this > > > > Thanks > > Wes > > > > On Fri, Oct 13, 2017 at 8:24 AM, Uwe L. Korn <[email protected]> wrote: > > > All, > > > > > > I propose that we accept the following release candidate as the > official > > > Apache Parquet C++ 1.3.1 release. > > > > > > Parquet C++ 1.3.1-rc0 includes the following: > > > --- > > > The CHANGELOG for the release is available at: > > > https://git-wip-us.apache.org/repos/asf?p=parquet-cpp.git&f= > CHANGELOG&hb=apache-parquet-cpp-1.3.1-rc0 > > > > > > The tag used to create the release candidate is: > > > https://git-wip-us.apache.org/repos/asf?p=parquet-cpp.git;a= > shortlog;h=refs/tags/apache-parquet-cpp-1.3.1-rc0 > > > > > > The release candidate is available at: > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parque > t-cpp-1.3.1-rc0/apache-parquet-cpp-1.3.1.tar.gz > > > > > > The MD5 checksum of the release candidate can be found at: > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parque > t-cpp-1.3.1-rc0/apache-parquet-cpp-1.3.1.tar.gz.md5 > > > > > > The signature of the release candidate can be found at: > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parque > t-cpp-1.3.1-rc0/apache-parquet-cpp-1.3.1.tar.gz.asc > > > > > > The GPG key used to sign the release are available at: > > > https://dist.apache.org/repos/dist/dev/parquet/KEYS > > > > > > The release is based on the commit hash > > > a1c950d889a22b267ecddaa3436d3494fcca3ae7. > > > > > > Please download, verify, and test. > > > > > > The vote will close on Mo 16. Okt 15:06:05 CEST 2017 > > > > > > [ ] +1 Release this as Apache Parquet C++ 1.3.1 > > > [ ] +0 > > > [ ] -1 Do not release this as Apache Parquet C++ 1.3.1 because... >
