[ 
https://issues.apache.org/jira/browse/PARQUET-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258648#comment-16258648
 ] 

ASF GitHub Bot commented on PARQUET-1095:
-----------------------------------------

cpcloud commented on issue #403: PARQUET-1095: [C++] Read and write Arrow 
decimal values
URL: https://github.com/apache/parquet-cpp/pull/403#issuecomment-345555398
 
 
   @wesm I have one more change, which removes the loop from `BytesToInteger` 
and uses integer arithmetic operations only, even for byte sizes that are not 
powers of two.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [C++] Read and write Arrow decimal values
> -----------------------------------------
>
>                 Key: PARQUET-1095
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1095
>             Project: Parquet
>          Issue Type: New Feature
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Assignee: Phillip Cloud
>             Fix For: cpp-1.4.0
>
>
> We now have 16-byte decimal values in Arrow which have been validated against 
> the Java implementation. We need to be able to read and write these to 
> Parquet format. 
> To make these values readable by Impala or some other Parquet readers may 
> require some work. It expects the storage size to match the decimal precision 
> exactly. So in parquet-cpp we will need to write the correct non-zero bytes 
> into a FIXED_LEN_BYTE_ARRAY of the appropriate size.
> We should validate this against Java Parquet implementations



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to