[
https://issues.apache.org/jira/browse/PARQUET-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261497#comment-16261497
]
ASF GitHub Bot commented on PARQUET-1165:
-----------------------------------------
wesm commented on a change in pull request #420: PARQUET-1165: Pin clang-format
version to 4.0
URL: https://github.com/apache/parquet-cpp/pull/420#discussion_r152405053
##########
File path: CMakeLists.txt
##########
@@ -483,16 +484,19 @@ endif (UNIX)
# "make format" and "make check-format" targets
############################################################
-if (${CLANG_FORMAT_FOUND})
- # runs clang format and updates files in place.
- add_custom_target(format ${BUILD_SUPPORT_DIR}/run-clang-format.sh
${CMAKE_CURRENT_SOURCE_DIR} ${CLANG_FORMAT_BIN} 1
- `find ${CMAKE_CURRENT_SOURCE_DIR}/src ${CMAKE_CURRENT_SOURCE_DIR}/tools
${CMAKE_CURRENT_SOURCE_DIR}/examples ${CMAKE_CURRENT_SOURCE_DIR}/benchmarks
-name \\*.cc -or -name \\*.h | sed -e '/_generated/g'`)
+# runs clang format and updates files in place.
+add_custom_target(format ${BUILD_SUPPORT_DIR}/run_clang_format.py
+ ${CLANG_FORMAT_BIN}
+ ${BUILD_SUPPORT_DIR}/clang_format_exclusions.txt
+ ${CMAKE_CURRENT_SOURCE_DIR}/src)
- # runs clang format and exits with a non-zero exit code if any files need to
be reformatted
- add_custom_target(check-format ${BUILD_SUPPORT_DIR}/run-clang-format.sh
${CMAKE_CURRENT_SOURCE_DIR} ${CLANG_FORMAT_BIN} 0
- `find ${CMAKE_CURRENT_SOURCE_DIR}/src ${CMAKE_CURRENT_SOURCE_DIR}/tools
${CMAKE_CURRENT_SOURCE_DIR}/examples ${CMAKE_CURRENT_SOURCE_DIR}/benchmarks
-name \\*.cc -or -name \\*.h | sed -e '/_generated/g'`)
-endif()
+# runs clang format and exits with a non-zero exit code if any files need to
be reformatted
+# TODO(wesm): Make this work in run_clang_format.py
+add_custom_target(check-format ${BUILD_SUPPORT_DIR}/run_clang_format.py
Review comment:
We'll need to copy in these files, and create the exclusions file, too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Pin clang-format version to 4.0
> -------------------------------------
>
> Key: PARQUET-1165
> URL: https://issues.apache.org/jira/browse/PARQUET-1165
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-cpp
> Reporter: Wes McKinney
> Assignee: Uwe L. Korn
> Fix For: cpp-1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
