[
https://issues.apache.org/jira/browse/PARQUET-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276089#comment-16276089
]
ASF GitHub Bot commented on PARQUET-1167:
-----------------------------------------
wesm commented on a change in pull request #421: PARQUET-1167: [C++]
FieldToNode function should return a status when throwing an exception
URL: https://github.com/apache/parquet-cpp/pull/421#discussion_r154536652
##########
File path: src/parquet/arrow/arrow-schema-test.cc
##########
@@ -807,5 +807,17 @@ TEST_F(TestConvertArrowSchema, ParquetFlatDecimals) {
CheckFlatSchema(parquet_fields);
}
+TEST(InvalidSchema, ParquetNegativeDecimalScale) {
+ const auto& type = ::arrow::decimal(23, -2);
+ const auto& field = ::arrow::field("f0", type);
+ const auto& arrow_schema = ::arrow::schema({field});
Review comment:
I don't believe the `&` has an effect here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] FieldToNode function should return a status when throwing an exception
> ----------------------------------------------------------------------------
>
> Key: PARQUET-1167
> URL: https://issues.apache.org/jira/browse/PARQUET-1167
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Affects Versions: cpp-1.2.0
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Fix For: cpp-1.3.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
