We should probably make sure we have agreement from the community on this before we move forward; either through replies to this thread or in discussion at the next sync. Thanks, Gabor!
On Thu, Jan 18, 2018 at 11:26 PM, Gabor Szadovszky < gabor.szadovs...@cloudera.com> wrote: > Created PARQUET-1198 <https://issues.apache.org/jira/browse/PARQUET-1198> > to track moving to java8. > > Cheers, > Gabor > > > On 18 Jan 2018, at 22:16, Ryan Blue <rb...@netflix.com.INVALID> wrote: > > > > I think we should move. JDK7 has been EOL for a couple years now and > it's a > > pain to even install an old JDK7 these days. > > > > rb > > > > On Thu, Jan 18, 2018 at 2:31 AM, Gabor Szadovszky < > > gabor.szadovs...@cloudera.com> wrote: > > > >> Hi, > >> > >> The last commit in parquet-mr master (c6764c4a0848abf1d581e22df8b33e > 28ee9f2ced) > >> does not build with jdk7 only with jdk8. We did not catch the issue > because > >> either Travis and me use jdk8 to build parquet-mr. (The source level in > the > >> pom.xml is set to 1.7 so both jdk7 and jdk8 should be able to build it > but > >> jdk7 fails with “invalid inferred types for T; inferred type does not > >> conform to declared bound(s)”.) > >> > >> I think we have 2 options: > >> 1. Fix the code so it compiles with both jdk7 and jdk8. In this case > >> Travis should be updated to check both otherwise we might have similar > >> issues in the future. > >> 2. Bump up source/target levels to java8. > >> > >> What do you think? > >> > >> Thanks, > >> Gabor > > > > > > > > > > -- > > Ryan Blue > > Software Engineer > > Netflix > > -- Ryan Blue Software Engineer Netflix
