[ 
https://issues.apache.org/jira/browse/PARQUET-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362539#comment-16362539
 ] 

ASF GitHub Bot commented on PARQUET-1196:
-----------------------------------------

wesm commented on a change in pull request #436: PARQUET-1196: Example 
parquet_arrow project
URL: https://github.com/apache/parquet-cpp/pull/436#discussion_r167907509
 
 

 ##########
 File path: cmake_modules/ThirdpartyToolchain.cmake
 ##########
 @@ -48,10 +48,6 @@ if (DEFINED ENV{THRIFT_HOME})
   set(THRIFT_HOME "$ENV{THRIFT_HOME}")
 endif()
 
-if (DEFINED ENV{ARROW_HOME})
-  set(ARROW_HOME "$ENV{ARROW_HOME}")
-endif()
 
 Review comment:
   Moving this to FindArrow.cmake was surprising, but I'm not sure if there's a 
better way

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [C++] Provide a parquet_arrow example project incl. CMake setup
> ---------------------------------------------------------------
>
>                 Key: PARQUET-1196
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1196
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cpp
>            Reporter: Uwe L. Korn
>            Assignee: Uwe L. Korn
>            Priority: Major
>             Fix For: cpp-1.4.0
>
>
> Currently we only provide a simple example for the low-level interface, we 
> should also provide an example for the prefered high-level parquet_arrow 
> interface. Additionally, we should provide a CMake project that shows how to 
> use parquet as a lib. This can then also be used in CI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to