[
https://issues.apache.org/jira/browse/PARQUET-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370323#comment-16370323
]
ASF GitHub Bot commented on PARQUET-1220:
-----------------------------------------
wesm closed pull request #440: PARQUET-1220: Don't build Thrift examples and
tutorials in the ExternalProject
URL: https://github.com/apache/parquet-cpp/pull/440
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cmake_modules/ThirdpartyToolchain.cmake
b/cmake_modules/ThirdpartyToolchain.cmake
index 09e30dfe..a9dc15cd 100644
--- a/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cmake_modules/ThirdpartyToolchain.cmake
@@ -181,6 +181,8 @@ if (NOT THRIFT_FOUND)
"-DCMAKE_INSTALL_RPATH=${THRIFT_PREFIX}/lib"
"-DBUILD_SHARED_LIBS=OFF"
"-DBUILD_TESTING=OFF"
+ "-DBUILD_EXAMPLES=OFF"
+ "-DBUILD_TUTORIALS=OFF"
"-DWITH_QT4=OFF"
"-DWITH_C_GLIB=OFF"
"-DWITH_JAVA=OFF"
@@ -188,6 +190,7 @@ if (NOT THRIFT_FOUND)
"-DWITH_HASKELL=OFF"
"-DWITH_CPP=ON"
"-DWITH_STATIC_LIB=ON"
+ "-DWITH_LIBEVENT=OFF"
)
set(THRIFT_STATIC_LIB_NAME "${CMAKE_STATIC_LIBRARY_PREFIX}thrift")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Don't build Thrift examples and tutorials in the ExternalProject
> ----------------------------------------------------------------------
>
> Key: PARQUET-1220
> URL: https://issues.apache.org/jira/browse/PARQUET-1220
> Project: Parquet
> Issue Type: Improvement
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Priority: Major
> Fix For: cpp-1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
