[
https://issues.apache.org/jira/browse/PARQUET-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370333#comment-16370333
]
ASF GitHub Bot commented on PARQUET-1233:
-----------------------------------------
wesm commented on a change in pull request #443: PARQUET-1233: Enable option to
switch between stl classes and boost c…
URL: https://github.com/apache/parquet-cpp/pull/443#discussion_r169399652
##########
File path: CMakeLists.txt
##########
@@ -399,6 +399,11 @@ else()
endif()
include(ThirdpartyToolchain)
+if (THRIFT_VERSION VERSION_LESS "0.11.0")
Review comment:
This might need to be a build option to toggle rather than using the version
number. I think in Thrift 0.11.0 there might be a way to build with
`boost:shared_ptr` support
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [CPP ]Enable option to switch between stl classes and boost classes for
> thrift header
> -------------------------------------------------------------------------------------
>
> Key: PARQUET-1233
> URL: https://issues.apache.org/jira/browse/PARQUET-1233
> Project: Parquet
> Issue Type: Bug
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
> Priority: Major
> Fix For: cpp-1.4.0
>
>
> Thrift 0.11.0 introduced breaking changes by defaulting to stl classes. This
> causes an issue with older thrift versions. The scope of this Jira is to
> enable an option to choose between stl and boost in parquet thrift header.
> https://thrift.apache.org/lib/cpp
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
