[
https://issues.apache.org/jira/browse/PARQUET-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404785#comment-16404785
]
ASF GitHub Bot commented on PARQUET-968:
----------------------------------------
costimuraru commented on issue #411: PARQUET-968 Add Hive/Presto support in
ProtoParquet
URL: https://github.com/apache/parquet-mr/pull/411#issuecomment-374205305
> costimuraru 3 days ago Owner
> @BenoitHanotte, we had a discussion a while back around the LIST wrapper
being REQUIRED:
> https://github.com/apache/parquet-mr/pull/411#issuecomment-301194565
>
> @BenoitHanotte
> BenoitHanotte 3 days ago
> I strongly believe the wrappers should be optional for the following
reasons:
>
> it is consistent with how Maps are handled
> it is consistent with the fact that parquet-protobuf does not write fields
if they have the default values (protobuf considers them cleared). this is
currently the case for primitives and complex messages, I would like
collections to behave the same way.
> every field is optional with protobuf 3
> I haven't seen any arguments for making the wrapper required in the first
place, was there a specific reason I am not aware of?
@julienledem, regarding your previous comment
(https://github.com/apache/parquet-mr/pull/411#issuecomment-301194565), is
there a specific reason for which the LIST wrapper needs to be `REQUIRED` and
not `OPTIONAL`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Hive/Presto support in ProtoParquet
> ---------------------------------------
>
> Key: PARQUET-968
> URL: https://issues.apache.org/jira/browse/PARQUET-968
> Project: Parquet
> Issue Type: Task
> Reporter: Constantin Muraru
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
