[ 
https://issues.apache.org/jira/browse/PARQUET-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417777#comment-16417777
 ] 

Benoit Hanotte commented on PARQUET-1259:
-----------------------------------------

As discussed today during the parquet-sync, support for protobuf 2 is dropped 
in favor of protobuf 3 as the later supports both 'proto2' and 'proto3' 
syntaxes, allowing for backward compatibility. Unit tests are also covering 
both syntaxes. 
parquet-protobuf may have been able to continue using it with protobuf 2 
instead of 3 because the base API are somehow compatible, however we can't 
commit to supporting both as it is not tested.
The support has been dropped in April 2017 with this commit: 
[https://github.com/apache/parquet-mr/commit/70f28810a5547219e18ffc3465f519c454fee6e5#diff-027029268e253c28f3ed7866525f3207]

Support for both versions will not be implemented since protobuf 3 offers 
backward compatiblity and supporting two implementations would be 
time-consuming.

The version bump should be announced in the next release's notes.

 

Unless a major objection is raised, I believe we can close this ticket 

> Parquet-protobuf support both protobuf 2 and protobuf 3
> -------------------------------------------------------
>
>                 Key: PARQUET-1259
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1259
>             Project: Parquet
>          Issue Type: New Feature
>    Affects Versions: 1.10.0, 1.9.1
>            Reporter: Qinghui Xu
>            Priority: Major
>
> With the merge of pull request: 
> [https://github.com/apache/parquet-mr/pull/407,] now it is protobuf 3 used in 
> parquet-protobuf, and this implies that it cannot work in an environment 
> where people are using protobuf 2 in their own dependencies because there is 
> some new API / breaking change in protobuf 3. People have to face a 
> dependency version conflict with next parquet-protobuf release (e.g. 1.9.1 or 
> 1.10.0).
> What if we support both protobuf 2 and protobuf 3 by providing 
> parquet-protobuf and parquet-protobuf2?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to