[
https://issues.apache.org/jira/browse/PARQUET-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429999#comment-16429999
]
ASF GitHub Bot commented on PARQUET-1267:
-----------------------------------------
jbapple-cloudera commented on issue #451: PARQUET-1267: [C++] replace "unsafe"
std::equal by std::memcmp
URL: https://github.com/apache/parquet-cpp/pull/451#issuecomment-379622998
How is `memcmp` any safer? This sounds like an issue with the compiler,
rather than the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> replace "unsafe" std::equal by std::memcmp
> ------------------------------------------
>
> Key: PARQUET-1267
> URL: https://issues.apache.org/jira/browse/PARQUET-1267
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-cpp
> Reporter: rip.nsk
> Priority: Trivial
>
> std::equal(first1, last1, first2, size) is considered unsafe by msvc, replace
> it by std::memcmp
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
