[
https://issues.apache.org/jira/browse/PARQUET-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448251#comment-16448251
]
ASF GitHub Bot commented on PARQUET-1262:
-----------------------------------------
majetideepak closed pull request #460: PARQUET-1262: Use the same BOOST_ROOT
and Boost_NAMESPACE for Thrift
URL: https://github.com/apache/parquet-cpp/pull/460
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cmake_modules/ThirdpartyToolchain.cmake
b/cmake_modules/ThirdpartyToolchain.cmake
index 690fd0b6..c23fea92 100644
--- a/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cmake_modules/ThirdpartyToolchain.cmake
@@ -205,6 +205,14 @@ if (NOT THRIFT_FOUND)
"-DWITH_LIBEVENT=OFF"
)
+ # Thrift also uses boost. Forward important boost settings if there were
ones passed.
+ if (DEFINED BOOST_ROOT)
+ set(THRIFT_CMAKE_ARGS ${THRIFT_CMAKE_ARGS} "-DBOOST_ROOT=${BOOST_ROOT}")
+ endif()
+ if (DEFINED Boost_NAMESPACE)
+ set(THRIFT_CMAKE_ARGS ${THRIFT_CMAKE_ARGS}
"-DBoost_NAMESPACE=${Boost_NAMESPACE}")
+ endif()
+
set(THRIFT_STATIC_LIB_NAME "${CMAKE_STATIC_LIBRARY_PREFIX}thrift")
if (MSVC)
if (PARQUET_USE_STATIC_CRT)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Use the same BOOST_ROOT and Boost_NAMESPACE for Thrift
> -------------------------------------------------------------
>
> Key: PARQUET-1262
> URL: https://issues.apache.org/jira/browse/PARQUET-1262
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-cpp
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Priority: Major
> Fix For: cpp-1.5.0
>
>
> When building Thrift using the ExternalProject facility, we do not pass on
> the variables for a custom Boost variant. Thus if the user uses a differently
> flavoured/located Boost, Thrift does not pick it up. As a cause of this, we
> explicitly build Thrift during the Arrow OS X Wheel build.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
