Thanks, Gabor! Looks good to me. Changing my vote to +1.
rb On Wed, May 9, 2018 at 5:20 AM, Gabor Szadovszky < gabor.szadovs...@cloudera.com> wrote: > Created PARQUET-1294 <https://issues.apache.org/jira/browse/PARQUET-1294> to > track it. > > Gabor > > > On 9 May 2018, at 13:42, Zoltan Ivanfi <z...@cloudera.com> wrote: > > Done. On the other hand, this is what the release scripts generate (with > the commit message "Apache Parquet MR $version RC${rc}" in which the > variables do not get expanded), so they will have to be updated as well. We > will add a JIRA for that. > > Zoltan > > On Tue, May 8, 2018 at 10:53 PM Ryan Blue <rb...@netflix.com.invalid> > wrote: > > +0 > > The signature is good and I was able to build and test. > > The release doesn't conform to a recently-updated policy change for > checksums. Specifically, the sha file should be named sha1 but sha512 is > recommended, and there should not be a md5 checksum: > http://www.apache.org/dev/release-distribution#sigs-and-sums > > Could you guys create a sha512 file and delete the other two checksums? > That would change my vote to a +1. > > rb > > On Tue, May 8, 2018 at 7:26 AM, Zoltan Ivanfi <z...@cloudera.com> wrote: > > +1 (binding) > > built and tested > verified signature > > I agree with Uwe that a verification script would be useful. > > Zoltan > > On Mon, May 7, 2018 at 5:37 PM Uwe L. Korn <uw...@xhochy.com> wrote: > > +1 (binding) > > * Built and tested on Debian 8 > * verified sha1 > * verified signature > > was quite a hassle to build with manually installing protobuf and > > thrift. > > For newer releases, there definitely needs to be a verification script > otherwise voting is quite a labor intensive process. > > Uwe > > On Mon, May 7, 2018, at 9:58 AM, Gabor Szadovszky wrote: > > Hi Uwe, > > I guess this is because you are building it with java8. The 1.8.3 > > branch > > is still on 1.6 (source and target) and travis is configured to use > jdk7. We also used jdk7 for the build. > > Cheers, > Gabor > > On 7 May 2018, at 09:46, Uwe L. Korn <uw...@xhochy.com> wrote: > > Hello, > > the build is failing for me with "[ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process > (default) on project parquet-generator: Error rendering velocity > > resource.: > > NullPointerException", exteneded stacktrace: > https://gist.github.com/xhochy/fd62748ba8c300a5f238a80e8bacfc90 > > > I can provide more information if you can tell me what you would > > need. > > > Uwe > > On Fri, May 4, 2018, at 2:12 PM, Gabor Szadovszky wrote: > > Hi everyone, > > Zoltan and I propose the following RC to be released as official > > Apache > > Parquet MR 1.8.3 release. > > The commit id is aef7230e114214b7cc962a8f3fc5aeed6ce80828 > * This corresponds to the tag: apache-parquet-1.8.3 > * > > > https://github.com/apache/parquet-mr/tree/aef7230e114214b7cc962a8f3fc5ae > > ed6ce80828 > > < > > > https://github.com/apache/parquet-mr/tree/aef7230e114214b7cc962a8f3fc5ae > > ed6ce80828 > > > > The release tarball, signature, and checksums are here: > * > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.8.3-rc0/ > > < > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.8.3-rc0/ > > > > You can find the KEYS file here: > * https://dist.apache.org/repos/dist/dev/parquet/KEYS > <https://dist.apache.org/repos/dist/dev/parquet/KEYS> > > Binary artifacts are staged in Nexus here: > * > > > https://repository.apache.org/content/groups/staging/org/apache/parquet/ > > < > > > https://repository.apache.org/content/groups/staging/org/apache/parquet/ > > > > This is a maintenance release created mainly for Spark containing > > 2 > > bug > > fixes related to the statistics handling. > See > > > https://github.com/apache/parquet-mr/blob/aef7230e114214b7cc962a8f3fc5ae > > ed6ce80828/CHANGES.md > > < > > > https://github.com/apache/parquet-mr/blob/aef7230e114214b7cc962a8f3fc5ae > > ed6ce80828/CHANGES.md> > > > for details. > > Please download, verify, and test. > > [ ] +1 Release this as Apache Parquet MR 1.8.3 > [ ] +0 > [ ] -1 Do not release this because… > > > > > > > > -- > Ryan Blue > Software Engineer > Netflix > > > -- Ryan Blue Software Engineer Netflix
