[
https://issues.apache.org/jira/browse/PARQUET-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480598#comment-16480598
]
ASF GitHub Bot commented on PARQUET-1213:
-----------------------------------------
zivanfi commented on a change in pull request #480: PARQUET-1213: Column
indexes: Limit index size
URL: https://github.com/apache/parquet-mr/pull/480#discussion_r189248966
##########
File path:
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/ColumnIndexBuilder.java
##########
@@ -195,13 +195,19 @@ int compareMinValues(PrimitiveComparator<Binary>
comparator, int index1, int ind
int compareMaxValues(PrimitiveComparator<Binary> comparator, int index1,
int index2) {
return 0;
}
+
+ @Override
+ int sizeOf(Object minMax) {
Review comment:
Could this be abstract instead? Additionally, in every other sizeOf()
implementation, de parameter is called value, not minMax.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Column indexes: Limit index size
> --------------------------------
>
> Key: PARQUET-1213
> URL: https://issues.apache.org/jira/browse/PARQUET-1213
> Project: Parquet
> Issue Type: Sub-task
> Reporter: Gabor Szadovszky
> Assignee: Gabor Szadovszky
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
