[
https://issues.apache.org/jira/browse/PARQUET-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544327#comment-16544327
]
ASF GitHub Bot commented on PARQUET-1349:
-----------------------------------------
wesm closed pull request #476: PARQUET-1349: [C++] PARQUET_RPATH_ORIGIN is not
picked by the build
URL: https://github.com/apache/parquet-cpp/pull/476
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 52f63d09..b53f5980 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -729,7 +729,6 @@ ADD_LIB(parquet
STATIC_LINK_LIBS ${LIBPARQUET_INTERFACE_LINK_LIBS}
ABI_VERSION ${PARQUET_ABI_VERSION}
SO_VERSION ${PARQUET_SO_VERSION}
- LIB_RPATH_ORIGIN ${PARQUET_RPATH_ORIGIN}
)
############################################################
diff --git a/cmake_modules/BuildUtils.cmake b/cmake_modules/BuildUtils.cmake
index a6341e5f..1ce891ca 100644
--- a/cmake_modules/BuildUtils.cmake
+++ b/cmake_modules/BuildUtils.cmake
@@ -17,7 +17,7 @@
function(ADD_LIB LIB_NAME)
set(options)
- set(one_value_args SHARED_LINK_FLAGS ABI_VERSION SO_VERSION LIB_BUILD_SHARED
LIB_BUILD_STATIC LIB_RPATH_ORIGIN)
+ set(one_value_args SHARED_LINK_FLAGS ABI_VERSION SO_VERSION LIB_BUILD_SHARED
LIB_BUILD_STATIC)
set(multi_value_args SOURCES STATIC_LINK_LIBS STATIC_PRIVATE_LINK_LIBS
SHARED_LINK_LIBS SHARED_PRIVATE_LINK_LIBS DEPENDENCIES)
cmake_parse_arguments(ARG "${options}" "${one_value_args}"
"${multi_value_args}" ${ARGN})
if(ARG_UNPARSED_ARGUMENTS)
@@ -64,7 +64,7 @@ function(ADD_LIB LIB_NAME)
LINK_PRIVATE ${ARG_SHARED_PRIVATE_LINK_LIBS})
endif()
- if (LIB_RPATH_ORIGIN)
+ if (PARQUET_RPATH_ORIGIN)
if (APPLE)
set(_lib_install_rpath "@loader_path")
else()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] PARQUET_RPATH_ORIGIN is not picked by the build
> -----------------------------------------------------
>
> Key: PARQUET-1349
> URL: https://issues.apache.org/jira/browse/PARQUET-1349
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Affects Versions: cpp-1.4.0
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Priority: Major
> Labels: pull-request-available
> Fix For: cpp-1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
