[
https://issues.apache.org/jira/browse/PARQUET-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560927#comment-16560927
]
ASF GitHub Bot commented on PARQUET-1360:
-----------------------------------------
wesm opened a new pull request #482: PARQUET-1360: Use conforming API style,
variable names in WriteFileMetaData functions
URL: https://github.com/apache/parquet-cpp/pull/482
Per comments in PARQUET-1348. I also upgraded clang-format to 6.0 here so
pardon the diff noise from that.
To summarize the style points:
* Don't pass `const std:shared_ptr<T>&` if `const T&` will do
* Don't pass `const std::shared_ptr<T>&` if `T*` will do
* I prefer to only use class static function members for alternate
constructors
* Out arguments after in arguments
* `lower_with_underscores` for variable names
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Minor API + style changes follow up to PARQUET-1348
> ---------------------------------------------------------
>
> Key: PARQUET-1360
> URL: https://issues.apache.org/jira/browse/PARQUET-1360
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-cpp
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: cpp-1.5.0
>
>
> see comments in https://github.com/apache/parquet-cpp/pull/481
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
