[
https://issues.apache.org/jira/browse/PARQUET-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625735#comment-16625735
]
ASF GitHub Bot commented on PARQUET-1400:
-----------------------------------------
gszadovszky closed pull request #105: PARQUET-1400: Deprecate parquet-mr
related code in parquet-format
URL: https://github.com/apache/parquet-format/pull/105
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/main/java/org/apache/parquet/format/InterningProtocol.java
b/src/main/java/org/apache/parquet/format/InterningProtocol.java
index 6297f1c1..31ef6554 100644
--- a/src/main/java/org/apache/parquet/format/InterningProtocol.java
+++ b/src/main/java/org/apache/parquet/format/InterningProtocol.java
@@ -35,8 +35,10 @@
* TProtocol that interns the strings.
*
* @author Julien Le Dem
- *
+ * @deprecated java code moved to the parquet-mr project: See
org.apache.parquet:parquet-format-structures; Will be
+ * removed from here
*/
+@Deprecated
public class InterningProtocol extends TProtocol {
private final TProtocol delegate;
diff --git a/src/main/java/org/apache/parquet/format/LogicalTypes.java
b/src/main/java/org/apache/parquet/format/LogicalTypes.java
index 7c63e41d..13012181 100644
--- a/src/main/java/org/apache/parquet/format/LogicalTypes.java
+++ b/src/main/java/org/apache/parquet/format/LogicalTypes.java
@@ -21,7 +21,10 @@
/**
* Convenience instances of logical type classes.
+ * @deprecated java code moved to the parquet-mr project: See
org.apache.parquet:parquet-format-structures; Will be
+ * removed from here
*/
+@Deprecated
public class LogicalTypes {
public static class TimeUnits {
public static final TimeUnit MILLIS = TimeUnit.MILLIS(new MilliSeconds());
diff --git a/src/main/java/org/apache/parquet/format/Util.java
b/src/main/java/org/apache/parquet/format/Util.java
index 55d61ff4..bae48789 100644
--- a/src/main/java/org/apache/parquet/format/Util.java
+++ b/src/main/java/org/apache/parquet/format/Util.java
@@ -53,8 +53,10 @@
* We use the TCompactProtocol to serialize metadata
*
* @author Julien Le Dem
- *
+ * @deprecated java code moved to the parquet-mr project: See
org.apache.parquet:parquet-format-structures; Will be
+ * removed from here
*/
+@Deprecated
public class Util {
public static void writeColumnIndex(ColumnIndex columnIndex, OutputStream
to) throws IOException {
diff --git a/src/main/java/org/apache/parquet/format/event/Consumers.java
b/src/main/java/org/apache/parquet/format/event/Consumers.java
index ea61d633..e57aa07e 100644
--- a/src/main/java/org/apache/parquet/format/event/Consumers.java
+++ b/src/main/java/org/apache/parquet/format/event/Consumers.java
@@ -42,8 +42,10 @@
* Entry point for reading thrift in a streaming fashion
*
* @author Julien Le Dem
- *
+ * @deprecated java code moved to the parquet-mr project: See
org.apache.parquet:parquet-format-structures; Will be
+ * removed from here
*/
+@Deprecated
public class Consumers {
/**
diff --git
a/src/main/java/org/apache/parquet/format/event/EventBasedThriftReader.java
b/src/main/java/org/apache/parquet/format/event/EventBasedThriftReader.java
index e88432fa..6d1f6b84 100644
--- a/src/main/java/org/apache/parquet/format/event/EventBasedThriftReader.java
+++ b/src/main/java/org/apache/parquet/format/event/EventBasedThriftReader.java
@@ -34,8 +34,10 @@
* Event based reader for Thrift
*
* @author Julien Le Dem
- *
+ * @deprecated java code moved to the parquet-mr project: See
org.apache.parquet:parquet-format-structures; Will be
+ * removed from here
*/
+@Deprecated
public final class EventBasedThriftReader {
private final TProtocol protocol;
diff --git a/src/main/java/org/apache/parquet/format/event/FieldConsumer.java
b/src/main/java/org/apache/parquet/format/event/FieldConsumer.java
index 2be4d6e2..c882dcc2 100644
--- a/src/main/java/org/apache/parquet/format/event/FieldConsumer.java
+++ b/src/main/java/org/apache/parquet/format/event/FieldConsumer.java
@@ -25,8 +25,10 @@
* To receive Thrift field events
*
* @author Julien Le Dem
- *
+ * @deprecated java code moved to the parquet-mr project: See
org.apache.parquet:parquet-format-structures; Will be
+ * removed from here
*/
+@Deprecated
public interface FieldConsumer {
/**
diff --git a/src/main/java/org/apache/parquet/format/event/TypedConsumer.java
b/src/main/java/org/apache/parquet/format/event/TypedConsumer.java
index 1d10ad60..4838de9e 100644
--- a/src/main/java/org/apache/parquet/format/event/TypedConsumer.java
+++ b/src/main/java/org/apache/parquet/format/event/TypedConsumer.java
@@ -40,8 +40,10 @@
* receive thrift events of a given type
*
* @author Julien Le Dem
- *
+ * @deprecated java code moved to the parquet-mr project: See
org.apache.parquet:parquet-format-structures; Will be
+ * removed from here
*/
+@Deprecated
abstract public class TypedConsumer {
abstract public static class DoubleConsumer extends TypedConsumer {
diff --git a/src/test/java/org/apache/parquet/format/TestUtil.java
b/src/test/java/org/apache/parquet/format/TestUtil.java
index 1adf0998..c91f8e27 100644
--- a/src/test/java/org/apache/parquet/format/TestUtil.java
+++ b/src/test/java/org/apache/parquet/format/TestUtil.java
@@ -30,6 +30,11 @@
import org.junit.Test;
import org.apache.parquet.format.Util.DefaultFileMetaDataConsumer;
+/**
+ * @deprecated java code moved to the parquet-mr project: See
org.apache.parquet:parquet-format-structures; Will be
+ * removed from here
+ */
+@Deprecated
public class TestUtil {
@Test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Deprecate parquet-mr related code in parquet-format
> ---------------------------------------------------
>
> Key: PARQUET-1400
> URL: https://issues.apache.org/jira/browse/PARQUET-1400
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-format
> Reporter: Gabor Szadovszky
> Assignee: Gabor Szadovszky
> Priority: Major
> Labels: pull-request-available
>
> There are java classes in the
> [parquet-format|https://github.com/apache/parquet-format] repo that shall be
> in the [parquet-mr|https://github.com/apache/parquet-mr] repo instead: [java
> classes|https://github.com/apache/parquet-format/tree/master/src/main] and
> [test classes|https://github.com/apache/parquet-format/tree/master/src/test]
> These classes shall be deprecated by mentioning they will be moved to the
> [parquet-mr|https://github.com/apache/parquet-mr] repo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
