+1 (binding) * Checked checksums, signature * Ran unit tests
Note that `mvn test` fails if Apache Thrift 0.10.0 or higher is installed. It looks like this is a problem with the Maven Thrift plugin and not a problem with parquet-format, but definitely a rough edge that will affect users [ERROR] thrift failed output: [WARNING:/home/wesm/Downloads/apache-parquet-format-2.6.0/src/main/thrift/parquet.thrift:295] The "byte" type is a compatibility alias for "i8". Use "i8" to emphasize the signedness of this type. [ERROR] thrift failed error: [FAILURE:generation:1] Error: unknown option java:hashcode - Wes On Fri, Sep 28, 2018 at 2:52 AM Gabor Szadovszky <[email protected]> wrote: > > +1 (non-binding) > > - Checked source tarball content > - Checked checksums, signature > > Cheers, > Gabor > > On Thu, Sep 27, 2018 at 5:10 PM Zoltan Ivanfi <[email protected]> > wrote: > > > +1 (binding) > > > > - contents look good > > - units tests pass > > - checksums match > > - signature matches > > > > Thanks, > > > > Zoltan > > > > On Thu, Sep 27, 2018 at 5:02 PM Nandor Kollar <[email protected] > > > > > wrote: > > > > > Hi everyone, > > > > > > I propose the following RC to be released as official Apache Parquet > > > Format 2.6.0 release. > > > > > > The commit id is df6132b94f273521a418a74442085fdd5a0aa009 > > > * This corresponds to the tag: apache-parquet-format-2.6.0 > > > * > > > > > https://github.com/apache/parquet-format/tree/df6132b94f273521a418a74442085fdd5a0aa009 > > > * > > > > > https://gitbox.apache.org/repos/asf?p=parquet-format.git;a=commit;h=df6132b94f273521a418a74442085fdd5a0aa009 > > > > > > The release tarball, signature, and checksums are here: > > > * > > > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-format-2.6.0-rc0 > > > > > > You can find the KEYS file here: > > > * https://dist.apache.org/repos/dist/dev/parquet/KEYS > > > > > > Binary artifacts are staged in Nexus here: > > > * > > > > > https://repository.apache.org/content/groups/staging/org/apache/parquet/parquet-format/2.6.0 > > > > > > This release includes following changes: > > > > > > PARQUET-1266 - LogicalTypes union in parquet-format doesn't include UUID > > > PARQUET-1290 - Clarify maximum run lengths for RLE encoding > > > PARQUET-1387 - Nanosecond precision time and timestamp - parquet-format > > > PARQUET-1400 - Deprecate parquet-mr related code in parquet-format > > > PARQUET-1429 - Turn off DocLint on parquet-format > > > > > > Please download, verify, and test. > > > > > > The voting will be open at least for 72 hour from now. > > > > > > [ ] +1 Release this as Apache Parquet Format 2.6.0 > > > [ ] +0 > > > [ ] -1 Do not release this because... > > > > > > Thanks, > > > Nandor > > > > >
