[ https://issues.apache.org/jira/browse/PARQUET-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643662#comment-16643662 ]
Antoine Pitrou commented on PARQUET-1354: ----------------------------------------- Isn't this fixed already? > [C++] Fix deprecated Arrow builder API usages > --------------------------------------------- > > Key: PARQUET-1354 > URL: https://issues.apache.org/jira/browse/PARQUET-1354 > Project: Parquet > Issue Type: Bug > Components: parquet-cpp > Reporter: Wes McKinney > Assignee: Wes McKinney > Priority: Blocker > Fix For: cpp-1.5.0 > > > I see warnings like the following: > {code} > [64/65] Building CXX object > src/parquet/arrow/CMakeF...reader-writer-test.dir/arrow-reader-writer-test.cc.o > In file included from ../src/parquet/arrow/test-util.h:23:0, > from ../src/parquet/arrow/arrow-reader-writer-test.cc:37: > ../src/parquet/arrow/test-util.h: In function 'void > parquet::arrow::ExpectArrayT(void*, arrow::Array*) [with ArrowType = > arrow::BooleanType]': > ../src/parquet/arrow/test-util.h:467:82: warning: 'arrow::Status > arrow::BooleanBuilder::Append(const uint8_t*, int64_t, const uint8_t*)' is > deprecated (declared at > /opt/conda/envs/pyarrow-dev/include/arrow/builder.h:711): Use AppendValues > instead [-Wdeprecated-declarations] > EXPECT_OK(builder.Append(reinterpret_cast<uint8_t*>(expected), > result->length())); > > ^ > In file included from > /opt/conda/envs/pyarrow-dev/include/arrow/compute/context.h:24:0, > from > /opt/conda/envs/pyarrow-dev/include/arrow/compute/api.h:21, > from ../src/parquet/arrow/arrow-reader-writer-test.cc:26: > ../src/parquet/arrow/test-util.h: In instantiation of 'typename > std::enable_if<std::is_same<ArrowType, > parquet::arrow::DecimalWithPrecisionAndScale<precision> >::value, > arrow::Status>::type parquet::arrow::NullableArray(size_t, size_t, uint32_t, > std::shared_ptr<arrow::Array>*) [with ArrowType = > parquet::arrow::DecimalWithPrecisionAndScale<38>; int precision = 38; > typename std::enable_if<std::is_same<ArrowType, > parquet::arrow::DecimalWithPrecisionAndScale<precision> >::value, > arrow::Status>::type = arrow::Status; size_t = long unsigned int; uint32_t = > unsigned int]': > ../src/parquet/arrow/arrow-reader-writer-test.cc:845:3: required from 'void > parquet::arrow::TestParquetIO_SingleColumnTableOptionalChunkedWrite_Test<gtest_TypeParam_>::TestBody() > [with gtest_TypeParam_ = parquet::arrow::DecimalWithPrecisionAndScale<38>]' > /opt/conda/envs/pyarrow-dev/include/arrow/builder.h:1042:20: required from > here > ../src/parquet/arrow/test-util.h:331:73: warning: 'arrow::Status > arrow::FixedSizeBinaryBuilder::Append(const uint8_t*, int64_t, const > uint8_t*)' is deprecated (declared at > /opt/conda/envs/pyarrow-dev/include/arrow/builder.h:1017): Use AppendValues > instead [-Wdeprecated-declarations] > RETURN_NOT_OK(builder.Append(out_buf->data(), size, valid_bytes.data())); > ^ > ../src/parquet/arrow/test-util.h: In instantiation of 'typename > std::enable_if<std::is_same<ArrowType, > parquet::arrow::DecimalWithPrecisionAndScale<precision> >::value, > arrow::Status>::type parquet::arrow::NonNullArray(size_t, > std::shared_ptr<arrow::Array>*) [with ArrowType = > parquet::arrow::DecimalWithPrecisionAndScale<38>; int precision = 38; > typename std::enable_if<std::is_same<ArrowType, > parquet::arrow::DecimalWithPrecisionAndScale<precision> >::value, > arrow::Status>::type = arrow::Status; size_t = long unsigned int]': > ../src/parquet/arrow/arrow-reader-writer-test.cc:791:3: required from 'void > parquet::arrow::TestParquetIO_SingleColumnTableRequiredChunkedWriteArrowIO_Test<gtest_TypeParam_>::TestBody() > [with gtest_TypeParam_ = parquet::arrow::DecimalWithPrecisionAndScale<38>]' > /opt/conda/envs/pyarrow-dev/include/arrow/builder.h:1042:20: required from > here > ../src/parquet/arrow/test-util.h:170:53: warning: 'arrow::Status > arrow::FixedSizeBinaryBuilder::Append(const uint8_t*, int64_t, const > uint8_t*)' is deprecated (declared at > /opt/conda/envs/pyarrow-dev/include/arrow/builder.h:1017): Use AppendValues > instead [-Wdeprecated-declarations] > RETURN_NOT_OK(builder.Append(out_buf->data(), size)); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)