This vote passes, with at least 3 binding +1 votes. Some votes are from before we made significant changes, so I'm not sure which ones to count. Regardless, thank you to everyone that took the time to review the proposal.
And thanks to Gidon for taking the lead and getting it done! rb On Wed, Jan 16, 2019 at 9:15 AM Wes McKinney <[email protected]> wrote: > +1 (binding). Sorry for the delay in reviewing. There are a lot of > moving parts here and different configurations (same key for footer > and columns, different keys, plaintext footer, etc.) and so the > implementations are justifiably going to be a lot of work. > > @Tham, per your comment > > > We are going to release our product with encrypted parquet soon > > I haven't seen the C++ encryption PR updated in a while. Have you been > doing development on this somewhere else? > > On Tue, Jan 15, 2019 at 8:37 PM [email protected] <[email protected]> wrote: > > > > Hi all, > > > > I’m working on C++ parquet encryption module and my project at Emotiv is > currently using it in development phase. We are going to release our > product with encrypted parquet soon. So I’ll appreciate a lot if we can > process voting procedure on crypto specification as soon as possible, then > we can continue with implementation and Java-C++ interop testing. > > > > Many thanks, > > Tham > > > > On 2019/01/08 17:08:01, Xinli shang <[email protected]> wrote: > > > Hi all, > > > > > > Can we have one more binding votes to sign off the encryption design > to let > > > us move on to implementation? Or, if you think 2 current binding > votes can > > > also be considered as sign off in this particular case, given this > design > > > has been extensively discussed in a year and we have tested it in our > > > staging environment with privates, please let us know. > > > > > > Once we are unblocked, we will work on the implementation and > integration > > > with our security ecosystem. Maybe someday, we can show the community > how > > > Parquet encryption can work in large scale production. I would be > really > > > appreciated if we can be unblocked. > > > > > > Xinli > > > > > > On Wed, Dec 19, 2018 at 9:58 AM Gidon Gershinsky <[email protected]> > wrote: > > > > > > > Hi all, > > > > > > > > This is to remind that we have 2 binding votes - and need one more > in order > > > > to sign off the encryption. > > > > > > > > Cheers, Gidon. > > > > > > > > On Sat, Dec 15, 2018 at 10:13 AM Zoltan Ivanfi > <[email protected]> > > > > wrote: > > > > > > > > > +1 (binding) > > > > > > > > > > Thanks for your efforts, Gidon! > > > > > > > > > > On Fri, Dec 14, 2018 at 6:55 PM Ryan Blue > <[email protected]> > > > > > wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > Thanks for all your work on this, Gidon! > > > > > > > > > > > > On Fri, Dec 14, 2018 at 9:48 AM Gidon Gershinsky < > [email protected]> > > > > > wrote: > > > > > > > > > > > > > Hello Parquet developers, > > > > > > > > > > > > > > After a productive round of discussions, we have a new enhanced > > > > version > > > > > > of > > > > > > > the design document. You can find it here: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/ggershinsky/parquet-format/blob/p1450-crypto-specification/Encryption.md > > > > > > > > > > > > > > This is a call for vote (either new, or resumption of the > previous > > > > one. > > > > > > If > > > > > > > you have voted +1 before, feel free to do that again :). > > > > > > > > > > > > > > Cheers, Gidon > > > > > > > > > > > > > > ---------- Forwarded message --------- > > > > > > > From: Gidon Gershinsky <[email protected]> > > > > > > > Date: Tue, Oct 16, 2018 at 11:11 AM > > > > > > > Subject: [VOTE] Modular Encryption design sign-off > > > > > > > To: <[email protected]> > > > > > > > > > > > > > > > > > > > > > Hello Parquet developers, > > > > > > > > > > > > > > Per the last sync discussion, it is time to call for a vote on > the > > > > > > Parquet > > > > > > > Modular Encryption design sign-off. The design doc can be > found at > > > > the > > > > > > > encryption branch of the parquet-format repository, > > > > > > > > > > > > https://github.com/apache/parquet-format/blob/encryption/Encryption.md > > > > > . > > > > > > > > > > > > > > The design is stable by now. This work had started 10 months > ago, has > > > > > > been > > > > > > > extensively reviewed - and implemented (in Java, partially in > C++), > > > > > by a > > > > > > > number of folks from different companies. To continue with the > > > > > > > implementation pull requests, we need the design to be formally > > > > signed > > > > > > off > > > > > > > by the community. > > > > > > > > > > > > > > Cheers, Gidon > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Ryan Blue > > > > > > Software Engineer > > > > > > Netflix > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Xinli Shang > > > > -- Ryan Blue Software Engineer Netflix
