May it cause any problems that we write the thrift structures in the parquet files (footer, page headers etc.) with a different version as before? It might require some tests if the older readers are able to read the files written with the new thrift. Any thoughts?
On Thu, Jan 24, 2019 at 8:49 PM Ryan Blue <[email protected]> wrote: > Why is it a problem that thrift can't be compiled with Java 11? We should > only have a binary dependency. > > +1 for moving thrift forward, though. > > On Thu, Jan 24, 2019 at 11:38 AM Driesprong, Fokko <[email protected]> > wrote: > > > Hi all, > > > > I would like to discuss updating the Thrift dependency to 0.12.0 of > > Parquet. In my effort to make Parquet forward compatible for JDK11 > > <https://github.com/apache/parquet-mr/pull/596>, I stumbled upon some > > issues. One of them that we still rely, in both the CI and documentation, > > on Thrift 0.9.3 (released October 2015). Unfortunately, this version of > > Thrift won't compile under Java11: > > [javac] Compiling 105 source files to > /home/travis/build/apache/parquet-mr > > /thrift-0.9.3/lib/java/build > > [javac] warning: [options] bootstrap class path not set in conjunction > with > > -source 5 > > [javac] error: Source option 5 is no longer supported. Use 6 or later. > > [javac] error: Target option 1.5 is no longer supported. Use 1.6 or > later. > > > > Target 1.5, feels a bit awkward, doesn't it? My main question to the > > dev-list is; is there any particular reason why we shouldn't update the > > Thrift dependency to 0.12.0. I know that it will have an impact on > Parquet, > > but if we want to support Java11, we need to move forward eventually. > > > > After updating the thrift-maven plugin > > <https://github.com/apache/parquet-mr/pull/600>, I was able to run the > CI > > against Thrift 0.12.0 <https://github.com/apache/parquet-mr/pull/601>. > > > > Cheers, Fokko > > > > > -- > Ryan Blue > Software Engineer > Netflix >
