[
https://issues.apache.org/jira/browse/PARQUET-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756242#comment-16756242
]
Wes McKinney commented on PARQUET-1519:
---------------------------------------
See macros in
https://github.com/apache/arrow/blob/master/cpp/src/parquet/util/visibility.h#L57
used to work around differences between gcc, clang, and MSVC
"extern template class" also has the unfortunate effect of making template
specializations trickier (they have to be declared BEFORE the use of "extern
template class"). This is too inflexible
> [C++] Remove use of "extern template class" from parquet/column_reader.h
> ------------------------------------------------------------------------
>
> Key: PARQUET-1519
> URL: https://issues.apache.org/jira/browse/PARQUET-1519
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-cpp
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: cpp-1.6.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> These declarations are doing little to improve compile times, and they
> produce esoteric linking issues. Like parquet/encoding.h, I'll also refactor
> these classes into virtual interfaces and move the implementation into
> column_reader.cc
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
