I see spotless could handle import order and remove unused import as well, we can make use of them step by step.
+1 to use spotless. On Thu, Jan 9, 2020 at 2:36 AM Ryan Blue <[email protected]> wrote: > +1 for spotless checks. > > On Wed, Jan 8, 2020 at 7:13 AM Driesprong, Fokko <[email protected]> > wrote: > > > Y'all, > > > > Recently Chen Junjie brought up the removal of trailing spaces within the > > code and the headers: > > https://github.com/apache/parquet-mr/pull/727#issuecomment-571562392 > > > > I've been looking into this and looked into if we can apply something > like > > checkstyle to let it fail on trailing whitespace. However, it comes up > with > > a LOT of warnings on improper formatting, short variables, wrong import > > orders, etc. > > For Apache Avro we've added Spotless as a maven plugin: > > https://github.com/diffplug/spotless. Unlike checkstyle, spotless will > > also > > fix the formatting. Would this be something that others find useful? > > The main problem is that we need to apply this to the codebase, and this > > will break a lot of PR's, and it will mess up a bit of the version > control, > > because a lot of lines will be changed: > > https://github.com/apache/parquet-mr/pull/730/ > > > > WDYT? > > > > Cheers, Fokko > > > > > -- > Ryan Blue > Software Engineer > Netflix >
