+1 for spotless. Maybe we can drain the PRs to the minimum and then apply it.
On Wed, Jan 8, 2020 at 6:06 PM Junjie Chen <[email protected]> wrote: > I see spotless could handle import order and remove unused import as well, > we can make use of them step by step. > > +1 to use spotless. > > > On Thu, Jan 9, 2020 at 2:36 AM Ryan Blue <[email protected]> > wrote: > > > +1 for spotless checks. > > > > On Wed, Jan 8, 2020 at 7:13 AM Driesprong, Fokko <[email protected]> > > wrote: > > > > > Y'all, > > > > > > Recently Chen Junjie brought up the removal of trailing spaces within > the > > > code and the headers: > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_parquet-2Dmr_pull_727-23issuecomment-2D571562392&d=DwIBaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=FQ88AmOZ4TMjDdqNBGu-ag&m=67nJPy6EMPJ0n6vvmvA69XKi8sc_o0JDgsVKKm54yh0&s=YlANPBgPH3FsI1EpSIvCrUld47yX3wRqb8SMlfwsdVM&e= > > > > > > I've been looking into this and looked into if we can apply something > > like > > > checkstyle to let it fail on trailing whitespace. However, it comes up > > with > > > a LOT of warnings on improper formatting, short variables, wrong import > > > orders, etc. > > > For Apache Avro we've added Spotless as a maven plugin: > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_diffplug_spotless&d=DwIBaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=FQ88AmOZ4TMjDdqNBGu-ag&m=67nJPy6EMPJ0n6vvmvA69XKi8sc_o0JDgsVKKm54yh0&s=cA6hUKdkxvyCXkRiu_WoPWuhJVmJqlg0_CkJ9604IPY&e= > . Unlike checkstyle, spotless will > > > also > > > fix the formatting. Would this be something that others find useful? > > > The main problem is that we need to apply this to the codebase, and > this > > > will break a lot of PR's, and it will mess up a bit of the version > > control, > > > because a lot of lines will be changed: > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_parquet-2Dmr_pull_730_&d=DwIBaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=FQ88AmOZ4TMjDdqNBGu-ag&m=67nJPy6EMPJ0n6vvmvA69XKi8sc_o0JDgsVKKm54yh0&s=_FCuNEszM8Q4yJh3U-uzwvUywfvYSJtrxv4fXcLtcuc&e= > > > > > > WDYT? > > > > > > Cheers, Fokko > > > > > > > > > -- > > Ryan Blue > > Software Engineer > > Netflix > > > -- Xinli Shang
