[
https://issues.apache.org/jira/browse/PARQUET-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013256#comment-17013256
]
ASF GitHub Bot commented on PARQUET-1753:
-----------------------------------------
belugabehr commented on pull request #738: PARQUET-1753: Ensure Parquet Version
slf4j Libraries Are Included In …
URL: https://github.com/apache/parquet-mr/pull/738
…parquet-thrift Module
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following
[PARQUET-1753](https://issues.apache.org/jira/browse/PARQUET/PARQUET-1753)
issues and references them in the PR title. For example, "PARQUET-1234: My
Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-1753
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ensure Parquet Version slf4j Libraries Are Included In parquet-thrift Module
> ----------------------------------------------------------------------------
>
> Key: PARQUET-1753
> URL: https://issues.apache.org/jira/browse/PARQUET-1753
> Project: Parquet
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
>
> {code:none}
> ### parquet-thrift
> [1;34mINFO] Excluding com.google.code.findbugs:jsr305:jar:3.0.0 from the
> shaded jar.
> [1;34mINFO] Excluding com.twitter.elephantbird:elephant-bird-core:jar:4.4
> from the shaded jar.
> [1;34mINFO] Excluding
> com.twitter.elephantbird:elephant-bird-hadoop-compat:jar:4.4 from the shaded
> jar.
> ***[1;34mINFO] Excluding org.slf4j:slf4j-api:jar:1.6.4 from the shaded jar.***
> [1;34mINFO] Excluding commons-lang:commons-lang:jar:2.4 from the shaded jar.
> [1;34mINFO] Excluding com.google.guava:guava:jar:11.0.1 from the shaded jar.
> {code}
> You can see that slf4j-api is version *1.6.4*. All other parquet modules are
> using *1.7.x*.
> 1.6.4 is being brought in by some old dependencies (primarily
> {{com.twitter.elephantbird}}).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
