[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

[GitBox]

shangxinli commented on a change in pull request #776:
URL: https://github.com/apache/parquet-mr/pull/776#discussion_r415440161



##########
File path: 
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
##########
@@ -463,14 +486,29 @@ ConvertedType 
convertToConvertedType(LogicalTypeAnnotation logicalTypeAnnotation
     }
   }
 
-  private void addRowGroup(ParquetMetadata parquetMetadata, List<RowGroup> 
rowGroups, BlockMetaData block) {
+  private void addRowGroup(ParquetMetadata parquetMetadata, List<RowGroup> 
rowGroups, BlockMetaData block,
+      InternalFileEncryptor fileEncryptor) throws IOException {
+    
     //rowGroup.total_byte_size = ;

Review comment:
       Can we remove this? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org