shangxinli commented on a change in pull request #776:
URL: https://github.com/apache/parquet-mr/pull/776#discussion_r422577368
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
##########
@@ -463,14 +486,29 @@ ConvertedType
convertToConvertedType(LogicalTypeAnnotation logicalTypeAnnotation
}
}
- private void addRowGroup(ParquetMetadata parquetMetadata, List<RowGroup>
rowGroups, BlockMetaData block) {
+ private void addRowGroup(ParquetMetadata parquetMetadata, List<RowGroup>
rowGroups, BlockMetaData block,
Review comment:
Not all the changes are isolated. Generally, adding 'if/else' will add
diverge the code and add the complexity. One other thing is regression
thinking. If fileEncryptor is null, which would be most of the case, then it
just executes the existing method without change. It would be less error prone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
