prakharjain09 commented on a change in pull request #789:
URL: https://github.com/apache/parquet-mr/pull/789#discussion_r416463221
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
##########
@@ -480,6 +480,10 @@ private void addRowGroup(ParquetMetadata parquetMetadata,
List<RowGroup> rowGrou
columnMetaData.getTotalSize(),
columnMetaData.getFirstDataPageOffset());
columnChunk.meta_data.dictionary_page_offset =
columnMetaData.getDictionaryPageOffset();
Review comment:
Use setDictionary_page_offset instead of
`columnChunk.meta_data.dictionary_page_offset =`. That will automatically
invoke setDictionary_page_offsetIsSet and we don't need to call it explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
