[ 
https://issues.apache.org/jira/browse/PARQUET-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107922#comment-17107922
 ] 

ASF GitHub Bot commented on PARQUET-1863:
-----------------------------------------

laurentgo opened a new pull request #792:
URL: https://github.com/apache/parquet-mr/pull/792


   By default, protoc-jar-maven-plugin adds generated source files into the
   main sources path but it can be configured to add them to the test
   sources path instead.
   
   Change the plugin configuration to do so, and remove use of the now
   obsolete build-helper-maven-plugin:add-test-source goal.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following 
[PARQUET-1863](https://issues.apache.org/jira/browse/PARQUET-1863) issues and 
references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason: Change to maven configuration. No functional change
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In 
addition, my commits follow the guidelines from "[How to write a good git 
commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain Javadoc that 
explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove use of add-test-source mojo in parquet-protobuf
> ------------------------------------------------------
>
>                 Key: PARQUET-1863
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1863
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-mr
>            Reporter: Laurent Goujon
>            Priority: Minor
>
> {{parquet-protobuf}} uses {{build-helper-maven-plugin:add-test-source}} maven 
> mojo to add protobuf test classes to the test sources path, but 
> {{protoc-jar-maven-plugin}} also adds these classes to the main sources path. 
> It is unnecessary ({{protoc-jar-maven-plugin}} could be configured to add to 
> the test classes path) and actually causes confusion with some IDE (Eclipse).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to