ggershinsky commented on a change in pull request #776:
URL: https://github.com/apache/parquet-mr/pull/776#discussion_r428455071
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
##########
@@ -442,7 +460,13 @@ static ParquetMetadata readSummaryMetadata(Configuration
configuration, Path bas
*/
@Deprecated
public static final ParquetMetadata readFooter(Configuration configuration,
Path file) throws IOException {
- return readFooter(configuration, file, NO_FILTER);
+ return readFooter(configuration, file, getDecryptionProperties(file,
configuration));
+ }
+
+ @Deprecated
+ public static final ParquetMetadata readFooter(Configuration configuration,
Path file,
Review comment:
These are encrypting versions of the existing `readFooter` functions,
already marked as deprecated, but still actively used (eg in parquet-cli and in
Spark). The deprecation comment says "@ deprecated will be removed in 2.0.0".
Since we are not at parquet 2.0 yet, I've marked the encrypting versions of
these functions as deprecated too, in order not to forget to handle them when
working on parquet-2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
