gszadovszky commented on a change in pull request #778:
URL: https://github.com/apache/parquet-mr/pull/778#discussion_r434550078
##########
File path:
parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java
##########
@@ -766,6 +768,33 @@ public void testReuseNameInNestedStructureAtSameLevel()
throws Exception {
testParquetToAvroConversion(NEW_BEHAVIOR, schema, parquetSchema);
}
+ @Test
+ public void testUUIDType() throws Exception {
+ Schema fromAvro = Schema.createRecord("myrecord", null, null, false,
+ Arrays.asList(new Schema.Field("uuid",
LogicalTypes.uuid().addToSchema(Schema.create(STRING)), null, null)));
+ String parquet = "message myrecord {\n" +
+ " required binary uuid (STRING);\n" +
+ "}\n";
+ Schema toAvro = Schema.createRecord("myrecord", null, null, false,
+ Arrays.asList(new Schema.Field("uuid", Schema.create(STRING), null,
null)));
+
+ testAvroToParquetConversion(fromAvro, parquet);
+ testParquetToAvroConversion(toAvro, parquet);
+ }
Review comment:
The
[`testRoundTripConversion`](https://github.com/apache/parquet-mr/blob/master/parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java#L144)
I'm using in `testUUIDTypeWithParquetUUID` is actually stronger than the one
you suggested: it checks for equality (in two phases) of the initial and the
result avro schemas (and not only for compatibility). For `testUUIDType`,
though it is a good idea to check the compatibility of the avro schemas.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
