gszadovszky commented on a change in pull request #778:
URL: https://github.com/apache/parquet-mr/pull/778#discussion_r421372389
##########
File path:
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveStringifier.java
##########
@@ -421,4 +422,30 @@ private String stringifyWithScale(BigInteger i) {
}
};
}
+
+ static final PrimitiveStringifier UUID_STRINGIFIER = new
PrimitiveStringifier("UUID_STRINGIFIER") {
+ private final char[] digit = "0123456789abcdef".toCharArray();
+ @Override
+ public String stringify(Binary value) {
+ byte[] bytes = value.getBytesUnsafe();
Review comment:
`final` would protect the reference only and not the values of the
array. Making a reference final in a local scope is usually required in
situations where it is accessed from e.g. lambda closures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
