maccamlc commented on pull request #798: URL: https://github.com/apache/parquet-mr/pull/798#issuecomment-649202469
> Thanks for working on this. > > You have changed every naming from `"map"` to `"key_value"` in the tests. This is good for the expected data but we should keep testing `"map"` at the read path as well. Based on the [spec](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#backward-compatibility-rules-1) it is still acceptable. > > I am not an expert in this topic so I would be happy if someone else also could review this. @gszadovszky no problem. I have tried to add a test to verify the backwards-compatibile reading. Added TestReadWriteMapKeyValue to the commit. Not sure if this is the correct way, but parsing a schema to go the logical type path with key_value and no MAP_KEY_VALUE type, then another with map and with the MAP_KEY_VALUE type. From what I can tell the name is not actually verified anywhere (I tried with random name value too :) ), but both test paths are successful. Hopefully it's ok, but let me know if might need to go a bit deeper somewhere else ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
