[ 
https://issues.apache.org/jira/browse/PARQUET-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148442#comment-17148442
 ] 

ASF GitHub Bot commented on PARQUET-1373:
-----------------------------------------

ggershinsky commented on a change in pull request #615:
URL: https://github.com/apache/parquet-mr/pull/615#discussion_r447508802



##########
File path: 
parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyMaterial.java
##########
@@ -0,0 +1,166 @@
+/*

Review comment:
       > .. With the correct annotations it can map a java object automatically.
   
   This approach seems to be optimal for objects with a fixed structure / 
fields - because it searches for all object fields in the json file. In our 
case, many fields are not always written (eg kms instance or url, if the key is 
for a column, and not for the footer; and other examples). Searching for them 
always is an overhead. Moreover, in case of internal storage, we don't need to 
parse two objects - key metadata and key material, because they are the same, 
so parsing one object is sufficient. The code we have today, performs only the 
search/parse of the relevant objects/fields, so it is optimal in that sense - 
and is also well-defined in one place. We can add more comments to the code to 
make the field parsing logic crystal clear. What do you think?
   
   > 
   > the format of these json objects is important for compatibility. We shall 
specify them or at least give an example in the comments.
   
   Sounds good. In addition to the comments mentioned above (that will be added 
to the relevant code lines), we will add a class comment to each relevant 
class, that documents the structure of the corresponding json.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Encryption key management tools 
> --------------------------------
>
>                 Key: PARQUET-1373
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1373
>             Project: Parquet
>          Issue Type: New Feature
>          Components: parquet-mr
>            Reporter: Gidon Gershinsky
>            Assignee: Gidon Gershinsky
>            Priority: Major
>
> Parquet Modular Encryption 
> ([PARQUET-1178|https://issues.apache.org/jira/browse/PARQUET-1178]) provides 
> an API that accepts keys, arbitrary key metadata and key retrieval callbacks 
> - which allows to implement basically any key management policy on top of it. 
> This Jira will add tools that implement a set of best practice elements for 
> key management. This is not an end-to-end key management, but rather a set of 
> components that might simplify design and development of an end-to-end 
> solution.
> This tool set is one of many possible. There is no goal to create a single or 
> “standard” toolkit for Parquet encryption keys. Parquet has a Crypto Factory 
> interface [(PARQUET-1817|https://issues.apache.org/jira/browse/PARQUET-1817]) 
> that allows to plug in different implementations of encryption key management.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to