shangxinli edited a comment on pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#issuecomment-672999165
Thanks @ggershinsky @gszadovszky for spending time on the discussion! If
both of you think adding 'metadata' field is not a good idea, I will just use
Configuration and see how it goes(majority wins :)). I understand which way is
better is subjective because both solutions have pros and cons. I am fine with
not adding the field now and we can revisit it when there are other needs that
require Parquet schema to have a metadata property to better align with other
schema's definition.
@ggershinsky for the RPC call configuration, I didn't mean it is used in the
case of my scenario. It could happen when building the CryptoPropertiesFactory
implementation, they can call some service to get those configurations
directly. What I was trying to point out is that there could be many ways to
get the crypto settings and it should be the user's choice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
