belugabehr edited a comment on pull request #820: URL: https://github.com/apache/parquet-mr/pull/820#issuecomment-702238058
Please add a test for setting field 1 and not setting field 2. Since setting the fields should reset the values for all other fields in the 'oneof' field, it could be possible that field 2, set to '0', would clear the value of the first field. If it just so happens that Parquet is loading the fields in the order they are defined, field 2 would be last and would overwrite all the previous values, and work simply because it is last. Need a test to demonstrate that the previous fields are not accidentally being cleared by 'null' values that come in later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
