[
https://issues.apache.org/jira/browse/PARQUET-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210991#comment-17210991
]
ASF GitHub Bot commented on PARQUET-1922:
-----------------------------------------
belugabehr commented on a change in pull request #825:
URL: https://github.com/apache/parquet-mr/pull/825#discussion_r501917260
##########
File path:
parquet-common/src/main/java/org/apache/parquet/bytes/LittleEndianDataOutputStream.java
##########
@@ -210,8 +207,8 @@ public final void writeDouble(double v) throws IOException {
writeLong(Double.doubleToLongBits(v));
}
- public void close() {
- IOExceptionUtils.closeQuietly(out);
+ public void close() throws IOException {
Review comment:
The inherited `close()` method throws IOException so this is fine to do
##########
File path:
parquet-column/src/main/java/org/apache/parquet/column/values/plain/PlainValuesWriter.java
##########
@@ -127,7 +127,6 @@ public void reset() {
@Override
public void close() {
arrayOut.close();
- out.close();
Review comment:
`out` in this case is wraps `arrayOut`, and it has no buffering, so it
does not need to be explicitly closed, or better, in the future, `out` should
be closed only and `arrayOut` will be closed implicitly. Anyway, I came to
this conclusion because this is how `close()` is implemented in a couple of
other Writer classes as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Deprecate IOExceptionUtils
> --------------------------
>
> Key: PARQUET-1922
> URL: https://issues.apache.org/jira/browse/PARQUET-1922
> Project: Parquet
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
