[
https://issues.apache.org/jira/browse/PARQUET-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218997#comment-17218997
]
ASF GitHub Bot commented on PARQUET-1922:
-----------------------------------------
gszadovszky commented on a change in pull request #825:
URL: https://github.com/apache/parquet-mr/pull/825#discussion_r510146819
##########
File path:
parquet-column/src/main/java/org/apache/parquet/column/values/plain/PlainValuesWriter.java
##########
@@ -127,7 +127,6 @@ public void reset() {
@Override
public void close() {
arrayOut.close();
- out.close();
Review comment:
I would either close only `arrayOut` but with comments about what you
have written here or close only `out` and catching the `IOException` that would
never occur and comment in the catch block similarly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Deprecate IOExceptionUtils
> --------------------------
>
> Key: PARQUET-1922
> URL: https://issues.apache.org/jira/browse/PARQUET-1922
> Project: Parquet
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
