[ 
https://issues.apache.org/jira/browse/PARQUET-1924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218565#comment-17218565
 ] 

ASF GitHub Bot commented on PARQUET-1924:
-----------------------------------------

Fokko merged pull request #827:
URL: https://github.com/apache/parquet-mr/pull/827


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Do not Instantiate a New LongHashFunction 
> ------------------------------------------
>
>                 Key: PARQUET-1924
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1924
>             Project: Parquet
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>
> {code:java|title=XxHash.java}
> /**
>  * The implementation of HashFunction interface. The XxHash uses XXH64 
> version xxHash
>  * with a seed of 0.
>  */
> public class XxHash implements HashFunction {
>   @Override
>   public long hashBytes(byte[] input) {
>     return LongHashFunction.xx(0).hashBytes(input);
>   }
>   @Override
>   public long hashByteBuffer(ByteBuffer input) {
>     return LongHashFunction.xx(0).hashBytes(input);
>   }
> {code}
> Since the seed is always zero, the {{static}} implementation provided by the 
> library can be used here.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to