[
https://issues.apache.org/jira/browse/PARQUET-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219114#comment-17219114
]
ASF GitHub Bot commented on PARQUET-1925:
-----------------------------------------
belugabehr commented on pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828#issuecomment-714581308
OK. I added a unit test. I don't love the test, but it's something (and
better than nothing). I'm also not sure how good of an example it will be for
future tests in this 'generator' project.
I ran into a host of issues trying to test this. It's probably best to, in
the future, change `Version` to implement an interface and then use normal
getters instead of static fields. Since this class is compiled without any
interface, there is nothing to import into the test at compile time in order to
cast it to something I can then easily test against.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Introduce Velocity Template Engine to Parquet Generator
> -------------------------------------------------------
>
> Key: PARQUET-1925
> URL: https://issues.apache.org/jira/browse/PARQUET-1925
> Project: Parquet
> Issue Type: New Feature
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
>
> Much easier than the current setup of manually outputting the strings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
