[
https://issues.apache.org/jira/browse/PARQUET-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228706#comment-17228706
]
ASF GitHub Bot commented on PARQUET-1925:
-----------------------------------------
gszadovszky commented on pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828#issuecomment-724140466
It looks good to me.
We already have the unit test
[VersionTest](https://github.com/apache/parquet-mr/blob/master/parquet-common/src/test/java/org/apache/parquet/VersionTest.java)
to validate `Version`. Writing this additional test for the code generation
made me more confident accepting this change.
I am not an expert of velocity but looks much better than our original code
so I would appreciate your work going forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Introduce Velocity Template Engine to Parquet Generator
> -------------------------------------------------------
>
> Key: PARQUET-1925
> URL: https://issues.apache.org/jira/browse/PARQUET-1925
> Project: Parquet
> Issue Type: New Feature
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
>
> Much easier than the current setup of manually outputting the strings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
