shangxinli commented on a change in pull request #856:
URL: https://github.com/apache/parquet-mr/pull/856#discussion_r561018198
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
##########
@@ -1046,6 +1046,8 @@ private ColumnIndexStore getColumnIndexStore(int
blockIndex) {
}
private RowRanges getRowRanges(int blockIndex) {
+ assert FilterCompat
Review comment:
This private method is only called in two places and both ensure NOOP
won't present. That is probably why the tests with NOOP in many places can
pass. Given it is a private method, that is fine but it reminds me that the
public method calculateRowRanges() doesn't check if the passed-in filter is
null/noop. Do we need to check that too?
Another question is should we use assert or exception because assert could
be turned off? There is some discussion about using assert or exception in
stack
overflow(https://stackoverflow.com/questions/1276308/exception-vs-assertion#:~:text=Use%20assertions%20for%20internal%20logic,should%20be%20explicit%20using%20exceptions.).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
