[
https://issues.apache.org/jira/browse/PARQUET-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268622#comment-17268622
]
ASF GitHub Bot commented on PARQUET-1964:
-----------------------------------------
gszadovszky commented on a change in pull request #856:
URL: https://github.com/apache/parquet-mr/pull/856#discussion_r560992936
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
##########
@@ -1046,6 +1046,8 @@ private ColumnIndexStore getColumnIndexStore(int
blockIndex) {
}
private RowRanges getRowRanges(int blockIndex) {
+ assert FilterCompat
Review comment:
We already test `NOOP` in many places because this one is the default if
no filter is present. `null` filter is only possible if the user explicitly
sets it to `null` in the `ParquetReadOptions`.
This assert is only to ensure that this private method will not be invoked
with a `null` or a `NOOP` filter? No "real" checking is required because the
callers are in the same class and they already check the filter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Properly handle missing/null filter
> -----------------------------------
>
> Key: PARQUET-1964
> URL: https://issues.apache.org/jira/browse/PARQUET-1964
> Project: Parquet
> Issue Type: Improvement
> Reporter: Yuming Wang
> Assignee: Gabor Szadovszky
> Priority: Major
>
> How to reproduce this issue:
> {code:scala}
> val hadoopInputFile = HadoopInputFile.fromPath(new
> Path("/path/to/parquet/000.snappy.parquet"), new Configuration())
> val reader = ParquetFileReader.open(hadoopInputFile)
> val recordCount = reader.getFilteredRecordCount
> reader.close()
> {code}
> Output:
> {noformat}
> java.lang.NullPointerException was thrown.
> java.lang.NullPointerException
> at
> org.apache.parquet.internal.filter2.columnindex.ColumnIndexFilter.calculateRowRanges(ColumnIndexFilter.java:81)
> at
> org.apache.parquet.hadoop.ParquetFileReader.getRowRanges(ParquetFileReader.java:961)
> at
> org.apache.parquet.hadoop.ParquetFileReader.getFilteredRecordCount(ParquetFileReader.java:766)
> {noformat}
> UPDATE: This is not only about the potential NPE if a {{null}} filter is set
> but to handle the missing/null filter in a better performing way. (Currently
> a NOOP filter implementation is used by default if no filter is set which
> requires to load the related data for column index/bloom filter even if no
> actual filtering will occur.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
