[
https://issues.apache.org/jira/browse/PARQUET-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277999#comment-17277999
]
ASF GitHub Bot commented on PARQUET-1970:
-----------------------------------------
ggershinsky commented on a change in pull request #861:
URL: https://github.com/apache/parquet-mr/pull/861#discussion_r569412617
##########
File path: parquet-common/src/main/java/org/apache/parquet/io/OutputFile.java
##########
@@ -31,5 +31,7 @@
long defaultBlockSize();
- String getPath();
+ default String getPath() {
+ throw new UnsupportedOperationException();
Review comment:
We're consuming this function in one of the encryption options:
https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java#L284
If there is no encryption, or encryption is used with a crypto factory that
doesn't need the file path - this exception will break the existing callers. A
simple way to resolve this is by catching the exception here, and passing a
null file path. This allows for these callers to run ok. The crypto factories
that do need the file path sometimes (like the one we have in parquet-mr)
should check `path==null` in situations where the file path is used, and throw
an exception there. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make minor releases source compatible
> -------------------------------------
>
> Key: PARQUET-1970
> URL: https://issues.apache.org/jira/browse/PARQUET-1970
> Project: Parquet
> Issue Type: Bug
> Affects Versions: 1.12.0
> Reporter: Gabor Szadovszky
> Assignee: Gabor Szadovszky
> Priority: Major
>
> Currently the compatibility checker ({{japicmp-maven-plugin}}) is configured
> to allow source incompatible changes for minor releases. It does not seem to
> be a great burden not allow such changes.
> Meanwhile a potential [bug|https://github.com/siom79/japicmp/issues/281] is
> discovered in the tool. Let's wait for this issue to be clarified because if
> it is not a bug then changes in parquet-mr will be required.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
