gszadovszky commented on a change in pull request #868:
URL: https://github.com/apache/parquet-mr/pull/868#discussion_r580860051
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java
##########
@@ -493,6 +492,9 @@ public void writeDictionaryPage(DictionaryPage
dictionaryPage,
dictionaryPage.getBytes().writeAllTo(out); // for encrypted column,
dictionary page bytes are already encrypted
encodingStatsBuilder.addDictEncoding(dictionaryPage.getEncoding());
currentEncodings.add(dictionaryPage.getEncoding());
+
+ // First data page comes just after the dictionary page
+ currentChunkFirstDataPage = out.getPos();
Review comment:
I'll move setting this value to data page writes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
