[ 
https://issues.apache.org/jira/browse/PARQUET-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293475#comment-17293475
 ] 

Gabor Szadovszky edited comment on PARQUET-1992 at 3/2/21, 7:56 AM:
--------------------------------------------------------------------

That's a good idea, [~junjie].

Another option would be to download the required parquet files using github 
direct links. We are downloading our dependencies during the build anyway so 
downloading some files additionally required by the testing should be 
acceptable. 
[~gershinsky], what do you think about listing the exact files in the pom do 
download them directly and remove the current git submodule configuration?


was (Author: gszadovszky):
That's a good idea, [~junjie].

Another option would be to download the required parquet files using github 
direct links. We are downloading our dependencies during the build anyway so 
downloading some files additionally required by the testing should be 
acceptable. 

> Cannot build from tarball because of git submodules
> ---------------------------------------------------
>
>                 Key: PARQUET-1992
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1992
>             Project: Parquet
>          Issue Type: Bug
>            Reporter: Gabor Szadovszky
>            Priority: Blocker
>
> Because we use git submodules (to get test parquet files) a simple "mvn clean 
> install" fails from the unpacked tarball due to "not a git repository".
> I think we would have 2 options to solve this situation:
> * Include all the required files (even only for testing) in the tarball and 
> somehow avoid the git submodule update in case of executed in a non-git 
> envrionment
> * Make the downloading of the parquet files and the related tests optional so 
> it won't fail the build from the tarball



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to