[ https://issues.apache.org/jira/browse/PARQUET-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298262#comment-17298262 ]
ASF GitHub Bot commented on PARQUET-1996: ----------------------------------------- emkornfield commented on a change in pull request #168: URL: https://github.com/apache/parquet-format/pull/168#discussion_r590639574 ########## File path: src/main/thrift/parquet.thrift ########## @@ -481,9 +481,10 @@ enum CompressionCodec { SNAPPY = 1; GZIP = 2; LZO = 3; - BROTLI = 4; // Added in 2.4 - LZ4 = 5; // Added in 2.4 - ZSTD = 6; // Added in 2.4 + BROTLI = 4; // Added in 2.4 + LZ4 = 5; // DEPRECATED (Added in 2.4) + ZSTD = 6; // Added in 2.4 + LZ4_RAW = 7; // Added in 2.9 Review comment: I don't think we should be too hasty to add LZ4 back into the spec, or at least we should narrow the scope. The integration of LZ4 with arrow has exposed problematic java implementations of LZ4: https://github.com/apache/arrow/pull/8949#issuecomment-794124675 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec > ------------------------------------------------------------------ > > Key: PARQUET-1996 > URL: https://issues.apache.org/jira/browse/PARQUET-1996 > Project: Parquet > Issue Type: Improvement > Components: parquet-format > Reporter: Antoine Pitrou > Priority: Major > > The current LZ4 codec is non-interoperable for reasons explained in details > on the parquet-dev mailing-list: > https://mail-archives.apache.org/mod_mbox/parquet-dev/202102.mbox/%3c20210216151401.7647ce37@fsol%3e -- This message was sent by Atlassian Jira (v8.3.4#803005)